Working 1.21 port (for the most part)#985
Conversation
# Conflicts: # Fabric/build.gradle # Forge/build.gradle # Forge/src/generated/resources/.cache/d4b3e6634c30118e1127c02b727ea285752e5aac # Neoforge/src/main/java/at/petrak/hexcasting/forge/loot/ForgeHexCypherLootMod.java
* Attempted fix of Networking (Incomplete) * Some minor fixes here and there
* Other fixes here and there (fixed up some whole minor folders so that's pretty cool) * Fixed NBTUtils!
* New ContainerInput for Recipes * Various edits to different Items * etc, this is setting up for a merge anyway
…visualizing on impeti scrying sight mishap) Fixed slate rendering both as a block entity and an item stack.
…n Fabric; might overhaul the registry with it. * Registered ItemApiLookups (ParticleSprays function on Fabric!!!) * Readded BrainsweepeeIngredient.getSomeKindOfReasonableIDForEmi(), EMI recipes work for the most part * Fixed Fabric Creative Tabs (mostly)
…r other things. * Fixed Fabric interop naming.
…(Not when erroring) * Adjusted Fabric creative mode tab entries (untested) * Fixed scrolls being unreadable * Fixed rendering artifacts when both toasts and casting stack are present on screen
…weep recipes, minor fixes on Fabric
…ve existed in the first place
|
A note for future reviewers: you can hide all JSON file changes to make the page work significantly faster 
|
|
Another note for future reviewers: if you use Bitwarden, apparently disabling its browser extension makes the review page work significantly faster??????? |
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
Mostly only reviewed Common, will come back and look through the platform code later. Left many questions/comments/suggestions.
I think my main concern is with how EntityIota was ported. I'm not sure how we want it to work, but I'm not satisfied with how it currently is. We can discuss it more on Discord.
github-project-automation
Bot
moved this from 📋 Backlog
to 🏗 In progress
in Hex Casting
Reverted NullIota and GarbageIota implementations, Adjusted various things, Got FabricRegister working, etc
Added new MishapEntityNotFound mishap documentation in Patchouli, among other things
… rendering too dark on slates... again
|
+38 406 -23 258 so far. |
|
Waiting for review. |
Updated the push branch in the PR workflow from 'main' to 'indev/1.21.1'.
Updated dependencies and modloader configurations for neoforge.
| @Override | ||
| public void readFromNbt(CompoundTag tag, HolderLookup.Provider registryLookup) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void writeToNbt(CompoundTag tag, HolderLookup.Provider registryLookup) { | ||
|
|
||
| } |
There was a problem hiding this comment.
Are these supposed to be empty? Do we need to add a TODO comment or something?
| // oh havoc, you think you're so funny | ||
| // the worst part is you're /right/ |
There was a problem hiding this comment.
Should this comment be removed (or moved to FabricHexInitializer) since the code it was commenting on is no longer here?
| int messageIdx = 0; | ||
| public static void init(IEventBus modBus) { | ||
| modBus.addListener(RegisterPayloadHandlersEvent.class, ev -> { | ||
| final PayloadRegistrar registar = ev.registrar("1"); |
There was a problem hiding this comment.
Typo: "registar" should be "registrar"
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
None of the remaining comments are blocking; I think I'm ok with merging this pretty much as-is and addressing remaining issues in followup PRs. Thanks everyone for your work on this!
…L jars fix(rendering): replace pattern rendering depth with VCDrawHelper depth reversal
5 participants
No description provided.